feat/3279 default block text #3283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
bfintal
requested changes
Aug 8, 2024
Comment on lines
69
to
75
|
|
||
| // Set the default block to stackable/text | ||
| if ( settings.stackable_text_default_block ) { | ||
| setTimeout( () => { | ||
| setDefaultBlockName( 'stackable/text' ) | ||
| } ) | ||
| } |
There was a problem hiding this comment.
Instead of adding it here in the global settings, you can create your own "default-text-block" plugin and register it using registerPlugin
bfintal
reviewed
Aug 15, 2024
|
@Arukuen When copy pasting 2 or more paragraphs, the first and last block is a Text block which is correct but the blocks in the middle are Paragraph blocks instead of Text blocks. Screen.Recording.2024-08-15.at.3.1.mp4 |
…re/paragraph in between
bfintal
requested changes
Aug 28, 2024
Comment on lines
4
to
5
| // Set the default block to stackable/text | ||
| setDefaultBlockName( 'stackable/text' ) |
There was a problem hiding this comment.
This might run multiple times, I believe this is a React Component
|
@Arukuen Remaining issue: Toggle setting disables upon refresh. Feature still works correctly but the toggle setting is showing it incorrectly. Screen.Recording.2024-09-02.at.10.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3279